feat: add agent set status to BoltAgent#1441
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 90.64% 90.64%
=======================================
Files 226 226
Lines 7182 7187 +5
=======================================
+ Hits 6510 6515 +5
Misses 672 672 ☔ View full report in Codecov by Sentry. |
|
@srtaalej I also changed the |
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
|
tyty @zimeg for speedy reviews and semver updates 🌠 excited to get this one merged 😁 |
| channel_id=channel or self._channel_id, # type: ignore[arg-type] | ||
| thread_ts=thread_ts or self._thread_ts, # type: ignore[arg-type] | ||
| status=status, | ||
| loading_messages=loading_messages, |
There was a problem hiding this comment.
suggestion(non-blocking): This can be a follow-up PR (probably better if it is). I think it would be really nice if Bolt provided sensible defaults.
status: "Thinking..." when no status is providedloading_messages:: a list of 5 fun, witty loading messages that are used when no loading messages are provided
This function is called a lot. So, it'll be nice if developers can start with agent.set_status() and have a solid experience out of the box. Then customize it later.
There was a problem hiding this comment.
i like this idea ⭐ working on it 🫡
There was a problem hiding this comment.
oh and yes i tested using the bolt-python-assistant-template 🚀
Summary
Add
set_status()toBoltAgentandAsyncBoltAgentfor setting assistant thread status directly from the agent listener argumentTesting
Category
slack_bolt.Appand/or its core componentsslack_bolt.Agentand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.